Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused tracer config gracefulShutdown #1692

Merged

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Nov 19, 2020

Which problem is this PR solving?

Remove obsolete code.

Short description of the changes

Graceful shutdown support was removed via #1522

Remove the corresponding configuration because it is not used anymore.

Refs: #1321

Graceful shutdown support was removed via
open-telemetry#1522

Remove the corresponding configuration because it is not used anymore.

Refs: open-telemetry#1321
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #1692 (5437d04) into master (7242c76) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1692   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files         165      165           
  Lines        5053     5053           
  Branches     1045     1045           
=======================================
  Hits         4617     4617           
  Misses        436      436           
Impacted Files Coverage Δ
packages/opentelemetry-tracing/src/config.ts 100.00% <ø> (ø)

@dyladan dyladan added internal enhancement New feature or request and removed internal labels Nov 25, 2020
@dyladan dyladan merged commit 8933661 into open-telemetry:master Nov 25, 2020
@Flarna Flarna deleted the rm-gracefulShutdown branch November 25, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants